Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #4071

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Fix CI #4071

merged 3 commits into from
Aug 1, 2018

Conversation

chnn
Copy link
Contributor

@chnn chnn commented Aug 1, 2018

Closes #4055

  • Empty cache before building ui on CircleCI
  • Remove unused targets from Makefile

@chnn
Copy link
Contributor Author

chnn commented Aug 1, 2018

Tests are failing due to Yarn registry downtime at the moment. You can never win 😝

Copy link
Contributor

@jaredscheib jaredscheib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. While we're here, would you mind fixing the fact that from time to time, both for me and for multiple other devs lately, make will fail after a make clean due to ui/build not existing? I believe changing line 88 to cd ui && mkdir build && yarn --no-progress --no-emoji would solve this.

@jaredscheib
Copy link
Contributor

My guess btw is that something like parcel-bundler/parcel#637 is what's causing CircleCI to fail. I've seen Parcel get stuck on different files during build, and never get over that hurdle. So presumably this is triggering Circle's 10m timeout rule. I've noticed that using make clean gets Parcel back into working order, so presumably yarn run clean will do the same thing, as implemented in this PR.

@chnn chnn merged commit b852695 into master Aug 1, 2018
@chnn chnn deleted the bugfix/circle branch August 1, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants