Initial error tests #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
force-pushed
the
initial-error-tests
branch
from
a4a946d
to
d02fc15
Compare
simlay
commented
Aug 12, 2021
| @@ -14,4 +14,5 @@ serde = "1.0.126" | |||
| env_logger = "0.8.3" | |||
| async-std = { version = "1.9.0", features = ["attributes"] } | |||
| tokio = { version = "1.3.0", features = ["macros"] } | |||
| fluvio-future = { version = "0.3.5", features = ["net"] } | |||
| fluvio-future = { version = "0.3.8", features = ["net"] } | |||
| fluvio = { git = "https://github.com/infinyon/fluvio" } | |||
There was a problem hiding this comment.
Using fluvio in the proxy to get the config should be removed.
simlay
commented
Aug 12, 2021
Comment on lines
+27
to
+30
| let config_file = ConfigFile::default_config()?; | ||
| let config = config_file.config(); | ||
| let cluster = config.current_cluster()?; | ||
| */ |
There was a problem hiding this comment.
Using fluvio in the proxy to get the config should be removed.
simlay
commented
Aug 12, 2021
Comment on lines
+4
to
+10
| try { | ||
| await fetch(`${base_url}/off`, { | ||
| method: 'GET', | ||
| }); | ||
| } catch (e) { | ||
| console.error(`${e.message}`); | ||
| } |
There was a problem hiding this comment.
This call would fail in firefox for me but if I recall correctly, it worked in chrome.
simlay
commented
Aug 12, 2021
| @@ -2,6 +2,7 @@ | |||
| "rust-analyzer": { | |||
| "cargo": { | |||
| "target": "wasm32-unknown-unknown" | |||
| } | |||
| }, | |||
| { "openCargoToml": true } | |||
There was a problem hiding this comment.
This isn't needed I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.