Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expo SDK 48, react-native 0.71.7 #2377

Merged
merged 27 commits into from
May 3, 2023
Merged

feat: Expo SDK 48, react-native 0.71.7 #2377

merged 27 commits into from
May 3, 2023

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Feb 14, 2023

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

Upgrades Ignite to Expo SDK 48 and React Native 0.71.7

  • Vanilla iOS
  • Vanilla Android
  • Expo iOS
  • Expo Android
  • Expo Web

@aymane-missouri-nw
Copy link
Contributor

aymane-missouri-nw commented Feb 23, 2023

@frankcalise in the actual version of detox 19.12.1 , in the package json , we seethe the version of jest in the peer dependencies is less Than 28, I think upgrading detox is the solution to use jest 29 and to fix the pipeline
Screenshot 2023-02-23 at 23 57 43

boilerplate/package.json Outdated Show resolved Hide resolved
@frankcalise frankcalise changed the title feat: Expo SDK 48, react-native 0.72.1 feat: Expo SDK 48, react-native 0.72.3 Feb 27, 2023
@anthonycmain
Copy link

anthonycmain commented Feb 28, 2023

Small typo in the issue title - says 72.3 not 71.3

@frankcalise frankcalise changed the title feat: Expo SDK 48, react-native 0.72.3 feat: Expo SDK 48, react-native 0.71.3 Feb 28, 2023
@carlosa54
Copy link
Contributor

@frankcalise Expo fixed the Can't resolve '@react-native/assets-registry/registry' webpack warning from expo-asset in expo/expo#21559.

yarn upgrade expo
npx expo install --fix

@frankcalise
Copy link
Contributor Author

@frankcalise Expo fixed the Can't resolve '@react-native/assets-registry/registry' webpack warning from expo-asset in expo/expo#21559.

yarn upgrade expo
npx expo install --fix

Thanks will take a look!!

@frankcalise
Copy link
Contributor Author

frankcalise commented Mar 29, 2023

@carlosa54

@frankcalise Expo fixed the Can't resolve '@react-native/assets-registry/registry' webpack warning from expo-asset in expo/expo#21559.

yarn upgrade expo
npx expo install --fix

Have you run into this error lately?

TypeError: (0 , _nonSecure.nanoid) is not a function

@carlosa54
Copy link
Contributor

Have you run into this error lately?

TypeError: (0 , _nonSecure.nanoid) is not a function

I did encounter that but can't remember which library it was, can you share the stacktrace or console log? There should be a hint of who's using nanoid. I think it was an issue with how it was imported

@carlosa54
Copy link
Contributor

@frankcalise Ok I remembered now, it was an issue with react-navigation. If you update it should not throw that error.

For reference I think it was fixed here

@frankcalise frankcalise changed the title feat: Expo SDK 48, react-native 0.71.3 feat: Expo SDK 48, react-native 0.71.6 Apr 21, 2023
Copy link
Contributor

@joshuayoes joshuayoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to some pairing with @frankcalise, we got the tests figured out.

  • Newest version of jest-runner can't handle processing itself, so we needed to ignore it
  • Some of the generator templates were out of date
  • Updating some of the android folder files broke how we rename the app identifier. Updated now

I've tested the changes on:

  • iOS
  • Android
  • Expo iOS
  • Expo Android
  • Expo Web

And this is ready to ship!

@frankcalise frankcalise changed the title feat: Expo SDK 48, react-native 0.71.6 feat: Expo SDK 48, react-native 0.71.7 Apr 26, 2023
@joshuayoes
Copy link
Contributor

joshuayoes commented Apr 26, 2023

This is now live for use under npx ignite-cli@8.8.0-beta.2 new or npx ignite-cli@beta new 🥳
https://www.npmjs.com/package/ignite-cli/v/8.8.0-beta.2

@joshuayoes joshuayoes merged commit 4238b32 into master May 3, 2023
1 check passed
@joshuayoes joshuayoes deleted the feat/expo-48 branch May 3, 2023 23:57
infinitered-circleci pushed a commit that referenced this pull request May 4, 2023
# [8.8.0](v8.7.0...v8.8.0) (2023-05-04)

### Features

* Expo SDK 48, react-native 0.71.7 ([#2377](#2377)) ([4238b32](4238b32))
@infinitered-circleci
Copy link

🎉 This PR is included in version 8.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants