Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.64.x #1641

Merged
merged 11 commits into from Apr 10, 2021
Merged

Conversation

nirre7
Copy link
Collaborator

@nirre7 nirre7 commented Mar 27, 2021

Please verify the following:

  • yarn ci:test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

Upgrades the boilerplate to React native 0.64.0

@ghost ghost mentioned this pull request Mar 28, 2021
@nirre7
Copy link
Collaborator Author

nirre7 commented Mar 28, 2021

Hi @jamonholmgren @bryanstearns

Seems that jest-expo depends on fbjs-scripts which is part of the react-native@^0.63.4 which it uses in assetFileTransformer.js (createCacheKeyFunction), as you can see in the build error.
Seems like react-native@0.64.0 uses another dependency => "@jest/create-cache-key-function" "^26.5.0".
I'm guessing that since expo does not support RN 0.64.x (afaik) this is not an issue for them, yet.

A workaround is to add fbjs-scripts as a temporary dev dependency (it works..) or Ignite needs to wait until expo supports 0.64.x? What do you guys think?

... The app runs though 😅

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing. Thanks @nirre7 !

@jamonholmgren jamonholmgren merged commit a49a222 into infinitered:master Apr 10, 2021
infinitered-circleci pushed a commit that referenced this pull request Apr 10, 2021
# [6.7.0](v6.6.0...v6.7.0) (2021-04-10)

### Features

* **boilerplate:** Upgrade to React Native 0.64.x ([#1641](#1641) by [@nirre7](https://github.com/nirre7)) ([a49a222](a49a222))
@infinitered-circleci
Copy link

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants