Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdebug-filter to reduce the time needed to collect coverage #781

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

maks-rafalko
Copy link
Member

Everything is explained here https://thephp.cc/news/2019/01/faster-code-coverage

Time before: 6.04 minutes
Time after: 4.05 minutes

for the same job that runs phpunit and generates coverage.

Which is a huge win IMO

Copy link
Member

@BackEndTea BackEndTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that speeds up CI is a 👍 for me

Maybe we could tell our users about this as well, in order for them to speed up infection runs.

Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maks-rafalko maks-rafalko added this to the 0.14.0 milestone Sep 10, 2019
@maks-rafalko
Copy link
Member Author

maks-rafalko commented Sep 10, 2019

Maybe we could tell our users about this as well, in order for them to speed up infection runs.

Well, I've added a tweet from Infection account about this feature: https://twitter.com/infection_php/status/1171519807167926272

I will also add this info to the blog post about 0.14.0 and, probably, to the documentation.

Thank you @BackEndTea & @localheinz

@maks-rafalko maks-rafalko merged commit 48bd81f into master Sep 10, 2019
@maks-rafalko maks-rafalko deleted the xdebug-filter branch September 10, 2019 20:29
@sanmai
Copy link
Member

sanmai commented Sep 11, 2019

I'm sorry that I'm late to the party, but you don't have to generate xdebug-filter.php every time. It is tied to our configuration so it can be generated once, committed to the repository, and left alone.

Though it does contain some absolute paths, there's nothing a __DIR__ couldn't help with.

@maks-rafalko
Copy link
Member Author

maks-rafalko commented Sep 11, 2019

The only one reason I didn't do it is to not forget to update it after phpunit.xml is modified. But let's see, now I think it's unlikely to happen.

Opened a PR #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants