Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony PHPUnitBridge #755

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

theofidry
Copy link
Member

This allows to:

  • Fail hard if our code is using (direct) deprecated code
  • Add a coverage listener which should improve how the coverage is measured

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the coverage listener

However, tests fail https://travis-ci.org/infection/infection/jobs/563212194#L959

@theofidry
Copy link
Member Author

What is the purpose of the test failed label? The CI state is now available in the PR list so it looks redundant and a bit annoying since needs to be handled manually

@maks-rafalko
Copy link
Member

maks-rafalko commented Jul 25, 2019

What is the purpose of the test failed label?

Very often, CI state is red because of MSI which we are not trying to increase for existing files. And I don't want to open Travis and see why the buids are failed, because of MSI or because of other issues (tests, etc.).

That's why it's easier to mark it as Tests Failed unless PR author fixes all the issues.

I've added it when one day I merged broken code to the master branch because I was too lazy to open Travis to see what is the reason of red status for the N-th time.

@maks-rafalko maks-rafalko added this to the 0.14.0 milestone Jul 25, 2019
@theofidry theofidry merged commit f915c7f into infection:master Jul 25, 2019
@theofidry theofidry deleted the feature/phpunit-bridge branch July 25, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants