Use codingmachine/safe #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
maks-rafalko
approved these changes
Jul 14, 2019
There was a problem hiding this comment.
Cool
what about adding phpstan rule to force using these functions?
We, and especially new contributors, will 100% forget to import safe's functions.
|
We can't add PHPStan plugins, because we use the phar, and the plugins require to use a composer dependency. (Due to scoping of the phar etc) |
|
Understood. Thank you @BackEndTea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
thecodingmachine/safeas a dependencyassertcalls and (mostly) useless casts.I can't fix everything at this moment, for example
preg_replacehas different return types bases on its parameters, and PHPStan can't understand that from the safe function. So i've opted to keep those as is right now.