Add PCOV to TravisCI #741
Merged
Add PCOV to TravisCI #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use $DRIVER instead of different env variables for each driver Enable xdebug when DRIVER=none to generate coverage Use correct env variable name to detect phpdbg in e2e tests Add default `env: DRIVER="xdebug"` and remove duplicate job Do not run pcov for phpspec e2e test Use composer install or composer update --prefer-lowest Remove mutators form PhpUnit_Depends_Order e2e test Add more tests for pcov
theofidry
reviewed
Jul 11, 2019
Shall we limit the lowest version to something more sensible? Like 8.2.4 which is the most current release now. That is totally our choice as this is our dev dependency. I went ahead and did that in #743 |
|
I think one way to tackle this issue is to detect whenever we're being run with |
|
@theofidry, @sanmai fixed your comments. New matrix
|
sanmai
reviewed
Jul 13, 2019
| script: | ||
| - if [[ $PHPDBG != 1 ]]; then xdebug-enable; fi | ||
| - if [[ $PHPDBG != 1 ]]; then $PHPUNIT_BIN; else phpdbg -qrr $PHPUNIT_BIN; fi | ||
| - if [[ "$DRIVER" == "xdebug" || "$DRIVER" == "none" ]]; then xdebug-enable; fi |
There was a problem hiding this comment.
So the point of DRIVER=none is to run Infection without any kind of coverage collector, with the coverage data we had from the initial PHPUnit run, am I right?
sanmai
approved these changes
Jul 13, 2019
|
Thank you @sanmai and @theofidry for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$PHPDBG,$NO_DEBUGGERetc. there is a$DRIVERenv variable that can bexdebug,phpdbg,pcov,none. Took idea from PHPUnit's travis configTeststage)pcovfor phpspec e2e test, it does not workcomposer installorcomposer update --prefer-lowestin ourE2ETestthat runs e2e tests inside PHPUnit. This fixes the issue when we run job on Travis with$DEPS="LOW", and Infection itself has the lowest dependencies (e.g. PHPUnit8.0.0), but e2e test has normal^8version wich is resolved to8.2.4atm. Error was:PHP Fatal error: Uncaught Error: Call to undefined method SebastianBergmann\Environment\Runtime::getCurrentSettings() in /home/travis/build/infection/infection/tests/Fixtures/e2e/Save_PHPUnit_Bootstrap_File/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:191PhpUnit_Depends_Ordere2e test. See explanation inside the diffCurrent testing matrix:
xdebugphpdbgpcov(NEW)nonexdebugphpdbgxdebugphpdbgnonexdebugphpdbgphpdbgphpdbgI'm not sure we need
pcovfor 7.3 and lowest dependencies. All of this increases a build time a lot.