Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Infection config builder: make sure it always creates an array for exluded dirs but not object #714

Merged
merged 1 commit into from Jun 24, 2019

Conversation

maks-rafalko
Copy link
Member

Fixes #580

array_unique([['a', 'a', 'b']) returns [0 => 'a', 2 => 'b'] which in its turn breaks infection.json because now we have an object

{
    "excludeDirs": {
        "0": "a",
        "2": "b",
    }
}

instead of array

{
    "excludeDirs": [
        "a",
        "b",
    ]
}

@maks-rafalko maks-rafalko added this to the 0.14.0 milestone Jun 24, 2019
@maks-rafalko maks-rafalko changed the title Wrap array_unique() with array_values() to ensure keys are always incremented Fix Infection config builder: make sure it always creates an array for exluded dirs but not object Jun 24, 2019
Copy link
Member

@BackEndTea BackEndTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Maybe this could target 0.13? as it is bugfix and not a new feature

Copy link
Member

@sidz sidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maks-rafalko maks-rafalko changed the base branch from master to 0.13 June 24, 2019 20:55
@maks-rafalko
Copy link
Member Author

Maybe this could target 0.13? as it is bugfix and not a new feature

retargeted

Thank you @BackEndTea, @sidz and @localheinz

@maks-rafalko maks-rafalko merged commit 2bc4a53 into 0.13 Jun 24, 2019
@maks-rafalko maks-rafalko deleted the fix-config-builder branch June 24, 2019 20:56
@maks-rafalko maks-rafalko modified the milestones: 0.14.0, 0.13.3 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants