Dramatically reduce memory usage by using classes instead of object-like arrays #710
Conversation
| return $self; | ||
| } | ||
|
|
||
| public static function with(string $testMethod, string $testFilePath, float $time): self |
There was a problem hiding this comment.
From what i can see this method isn't used outside of the tests. Meaning we can probably remove this, as well as the properties that it sets.
There was a problem hiding this comment.
properties are used here https://github.com/infection/infection/pull/710/files#diff-d0cc0b68f2e397d7080d2f7c58834ce3R236, we can't remove them.
Test method still used in tests only though
|
I had a go at using this in CircleCI to test Psalm. Installed from commit ec775c9 via composer. Unfortunately I'm still getting the same sort of failures. Strangely it took less time to fail when I increased the memory limit, but I suspect that may just be random variation: https://circleci.com/gh/bdsl/psalm/494 |
|
I would be interesting to run a blackfire profile to see the memory difference. That said, since the difference is still easy to see even without profiling I'd say it's more out of curiosity than a necessity |
|
@bdsl a good profiling could help out, but it's also very likely that the coverage data is just horribly big. We can work on making it better, but ultimately you do need more resources or alternatively leverage incremental mutations, i.e. filter out the unchanged files, instead of running Infection against the whole codebase all the time |
|
Does this improve speed as well? |
|
It may or may not, but this is not the place where Infection spend most of the time. So that the overall difference in run times excepted to negligible. |
…ve DX, typehints, and the codebase in general Everything is based on this article: https://steemit.com/php/@crell/php-use-associative-arrays-basically-never Objects of DTO classes takes less memory in PHP and as performant as arrays. Moreover, instead of `array` typehint we now have a real classes or typed collections
maks-rafalko
force-pushed
the
objects-instead-of-arrays
branch
from
b0d0328
to
3e6a39a
Compare
|
@sidz done |
|
Cool one :) |
All proofs are here: https://steemit.com/php/@crell/php-use-associative-arrays-basically-never
arraytypehints we now have a real classes or typed collections, which is a big win IMO.&$coverage)This PR follows #708 as @sanmai requested, I just extracted it to another PR for easier reviews.
Partially fixes issue #705
What is the memory benefit?
memory_limit=12Gmemory_limit=12Gmemory_limit=5GSo it is
7Gbor58%less memory usage for Psalm case.