Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore property for each Mutator in JSON schema. #699

Merged
merged 3 commits into from Jun 10, 2019

Conversation

maks-rafalko
Copy link
Member

This PR:

There were the same bugs for MBString and BCMath mutators.

Targeted to 0.13 to release as 0.13.2

Fixes #698

Add tests to prevent such issues in the future for any new mutators.
Add `helmich/phpunit-json-assert` for convenient JSON schema testing in PHPUnit
@sanmai
Copy link
Member

sanmai commented Jun 10, 2019

phpunit/phpunit 8.2.1 conflicts with helmich/phpunit-json-assert[v2.1.0].

But there's version 3.0 ofr helmich/phpunit-json-assert which should work with phpunit 8.

composer.json Outdated Show resolved Hide resolved
@maks-rafalko maks-rafalko added this to the 0.13.2 milestone Jun 10, 2019
@maks-rafalko maks-rafalko merged commit f521704 into 0.13 Jun 10, 2019
@maks-rafalko maks-rafalko deleted the bugfix/json-schema-ignore branch June 10, 2019 19:27
@maks-rafalko
Copy link
Member Author

Thank you @sanmai, I've updated it with ^2.1 || ^3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants