Chore/phpstan upgrade #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
maks-rafalko
previously approved these changes
May 2, 2019
BackEndTea
force-pushed
the
chore/phpstan-upgrade
branch
from
b7de2e9
to
2c491d7
Compare
BackEndTea
force-pushed
the
chore/phpstan-upgrade
branch
from
2c491d7
to
be84846
Compare
maks-rafalko
previously approved these changes
May 12, 2019
sanmai
reviewed
May 15, 2019
|
I fixed the issue in the |
sanmai
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Nodeclass missing properties or methodsBlocked by #685 Since that fixes issues surrounding names on nodes for decrement integer
That last one is the biggest change here. In most cases it means updating the doc comment to accurately reflect what is actually going into the method.
In some other cases it means assigning a property to a value, and then telling PHPStan what it is through
/** @var */notation.The big upside of no longer ignoring these issues is that we now are notified of errors with
$node->nameduring development. Like the ones found in:What do you think, should we stop ignoring these errors, and have a bit more code, like in this PR?
Or should we ignore the errors like previously?
Or should we add rules for specific files, stating for exactly which files these rules can be ignored?