Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#597 Array item removal mutator #649

Merged
merged 8 commits into from Mar 9, 2019
Merged

#597 Array item removal mutator #649

merged 8 commits into from Mar 9, 2019

Conversation

majkel89
Copy link
Contributor

@majkel89 majkel89 commented Mar 3, 2019 •
edited by maks-rafalko

This PR:

Fixes #597

@majkel89 majkel89 marked this pull request as ready for review March 3, 2019 09:30
@maks-rafalko maks-rafalko self-requested a review March 4, 2019 04:45
maks-rafalko
maks-rafalko previously approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this mutator!

Added a couple of comments. Also, documentation PR should be opened in infection/site repo.

src/Mutator/Removal/ArrayItemRemoval.php Outdated Show resolved Hide resolved
src/Mutator/Removal/ArrayItemRemoval.php Show resolved Hide resolved
@majkel89 majkel89 mentioned this pull request Mar 5, 2019
Merged
@majkel89
Copy link
Contributor Author

majkel89 commented Mar 5, 2019

PR for doc already provided

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Mar 6, 2019
BackEndTea
BackEndTea previously approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@BackEndTea BackEndTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Besides the few comments i had, this is a great PR, and the configuration has sane defaults.

@BackEndTea BackEndTea mentioned this pull request Mar 6, 2019
Closed
@maks-rafalko
Copy link
Member

Build is failing

@majkel89
Copy link
Contributor Author

majkel89 commented Mar 8, 2019

Build has been fixed

maks-rafalko
maks-rafalko approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @majkel89 👍

@maks-rafalko maks-rafalko merged commit cf8c3c5 into infection:master Mar 9, 2019
@ghost ghost removed the Needs Review label Mar 9, 2019
@jakzal jakzal mentioned this pull request Jun 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

@BackEndTea BackEndTea BackEndTea left review comments

Assignees
No one assigned
Labels
Mutator
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

New mutator proposal: remove item from literal array
3 participants
@majkel89 @maks-rafalko @BackEndTea