Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test more versions on php 7.3 #646

Merged
merged 1 commit into from Feb 22, 2019
Merged

Test more versions on php 7.3 #646

merged 1 commit into from Feb 22, 2019

Conversation

BackEndTea
Copy link
Member

This PR:

  • Adds extra CI runs for php 7.3.

We didn't have these initially because php 7.3 didn't have Xdebug yet.

@sanmai
Copy link
Member

sanmai commented Feb 22, 2019

Build is failing because of #631

The minimum required MSI percentage should be 90%, but actual is 79%.

@maks-rafalko maks-rafalko merged commit e295974 into master Feb 22, 2019
@maks-rafalko
Copy link
Member

Thank you @BackEndTea

@maks-rafalko maks-rafalko deleted the BackEndTea-patch-1 branch February 22, 2019 04:21
@BackEndTea
Copy link
Member Author

Thank you @borNfreee @sanmai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BackEndTea @sanmai @maks-rafalko