Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #644: Add the new unwrap mutator ucwords. #645

Merged
merged 2 commits into from Feb 19, 2019
Merged

Issue #644: Add the new unwrap mutator ucwords. #645

merged 2 commits into from Feb 19, 2019

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 18, 2019

This PR:

Fixes: #644

Related: #514

sanmai
sanmai previously approved these changes Feb 19, 2019
Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

BTW, you don't have to open an issue for every PR like this one. Just a PR is fine.

@drupol
Copy link
Contributor Author

drupol commented Feb 19, 2019

Sorry it's just an habit at work and other project. Basically it helps me finding a proper name for the branch :-)

@localheinz
Copy link
Member

@drupol

What do you think about adding a test case that shows that the mutator works correctly when the $delimiter parameter is present?

For reference, see http://php.net/manual/en/function.ucwords.php.

@drupol
Copy link
Contributor Author

drupol commented Feb 19, 2019

@drupol

What do you think about adding a test case that shows that the mutator works correctly when the $delimiter parameter is present?

For reference, see http://php.net/manual/en/function.ucwords.php.

Ok will update the PR.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Feb 19, 2019
@maks-rafalko maks-rafalko mentioned this pull request Feb 19, 2019
46 tasks
@maks-rafalko maks-rafalko merged commit 2c00447 into infection:master Feb 19, 2019
@maks-rafalko
Copy link
Member

Thank you @drupol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants