Add a few more count esque functions to not decrement against #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
maks-rafalko
previously approved these changes
Feb 17, 2019
There was a problem hiding this comment.
👍
It would be nice to add tests for new functions as well. At least mutant won't be killed when we implement this mutator #597, which is not a good thing
localheinz
previously approved these changes
Feb 17, 2019
| @@ -44,7 +44,7 @@ | |||
| */ | |||
| final class DecrementInteger extends Mutator | |||
| { | |||
| private const COUNT_NAMES = ['count', 'sizeof']; | |||
| private const COUNT_NAMES = ['count', 'grapheme_strlen', 'iconv_strlen', 'mb_strlen', 'sizeof', 'strlen']; | |||
There was a problem hiding this comment.
What do you think about starting to wrap here sooner or later?
sanmai
previously approved these changes
Feb 18, 2019
They dont need decrementing for the same reason as count functions.
BackEndTea
dismissed stale reviews from maks-rafalko, sanmai, and localheinz
via
c1ba65e
BackEndTea
force-pushed
the
enhancement/add-more-count-like
branch
from
74d1ec3
to
c1ba65e
Compare
|
Thank you @borNfreee, @sanmai & @localheinz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They dont need decrementing for the same reason as count functions.