Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-progress option to differentiate between progress bars output #618

Merged
merged 3 commits into from Feb 10, 2019

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Jan 28, 2019

This PR:

  • Adds new option --no-progress to differentiate between progress bars output. The name is not related to progress bars only, it will be used for any CI-related things.
  • Covered by tests
  • Doc updated

Fixes #613


From #613

Another option is to use something like the DotFormatter instead of the progress bars.

Current implementation saves the number of files/mutations generated in strings, which gives more useful information for developer (as well as with debugging for maintainers) rather than dots.

Before:

ci-2

After:

ci-2

❗️ We can also implement Travis autodetection to enable new loggers automatically even if --ci-friendly is not passed by developer. WDYT?


This change is Reviewable

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Jan 28, 2019
@sanmai
Copy link
Member

sanmai commented Jan 29, 2019

Travis and CI autodetection is the way it should work. It is as simple as checking for presence of any two below environment variables:

CI=true
CONTINUOUS_INTEGRATION=true

@sanmai
Copy link
Member

sanmai commented Jan 29, 2019

What do you think about renaming this option into --no-progress? This way it will be obvious exactly what it does, and it is a common standard option for other tools. E.g. composer has it.

@maks-rafalko
Copy link
Member Author

maks-rafalko commented Jan 29, 2019

  • Renamed to --no-progress (however, I still think --ci-friendly may be useful if we are going to extend its meaning not for progress bars only, but i'm ok with --no-progress)
  • Added CI autodetection

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maks-rafalko maks-rafalko changed the title Add --ci-friendly option to differentiate between progress bars output Add --no-progress option to differentiate between progress bars output Jan 30, 2019
@maks-rafalko
Copy link
Member Author

Thanks @sanmai for the review

@maks-rafalko maks-rafalko merged commit 0c028b4 into 0.12 Feb 10, 2019
@maks-rafalko maks-rafalko deleted the ci-friendly-output branch February 10, 2019 18:24
@sanmai
Copy link
Member

sanmai commented Feb 11, 2019

No problem, please ask me anytime if there's a need for a second set of eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants