Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement UnwrapArrayCombine mutator #550

Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 5, 2018

This PR

Related to #514.

πŸ’β€β™‚οΈ Follows the example in #513.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have thought twice before writing this comment, I'm sorry.


Unfortunately, this leads to warning that by default will lead to the failed test, hence killed mutant

Warning: array_combine() expects exactly 2 parameters, 1 given in /in/kdB8P on line 3

https://3v4l.org/kdB8P

maks-rafalko
maks-rafalko previously approved these changes Nov 5, 2018
@maks-rafalko maks-rafalko added this to the 0.11.0 milestone Nov 5, 2018
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@maks-rafalko
Copy link
Member

Thank you @localheinz

@maks-rafalko maks-rafalko merged commit e33dee5 into infection:master Nov 7, 2018
@localheinz localheinz deleted the feature/unwrap-array-combine branch November 7, 2018 09:52
@localheinz
Copy link
Member Author

Thank you, @borNfreee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants