Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rector's AddCoversClassAttributeRector rule #1962

Merged
merged 2 commits into from May 14, 2024

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented May 12, 2024

Actually, I have already applied this rule previously for Infection's codebase when created it locally. Now it's enabled and will fix all future tests after new Rector 1.0.5 is released, so we can use it from the Rector's core.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sanmai sanmai dismissed github-actions’s stale review May 13, 2024 00:40

No tests are necessary here.

Base automatically changed from feature/new-rector to master May 14, 2024 08:22
@maks-rafalko maks-rafalko merged commit 97818a8 into master May 14, 2024
56 checks passed
@maks-rafalko maks-rafalko deleted the feature/covers-class-rector branch May 14, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants