Upgrade Rector and fix new issues #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
maks-rafalko
force-pushed
the
feature/new-rector
branch
from
fb96b6b
to
ef92609
Compare
sanmai
reviewed
May 13, 2024
| @@ -46,10 +45,6 @@ | |||
| */ | |||
| final class CoveredTraceProvider implements TraceProvider | |||
| { | |||
| /** | |||
| * @param PhpUnitXmlCoverageTraceProvider|TraceProvider $primaryTraceProvider | |||
| * @param BufferedSourceFileFilter|FileFilter $bufferedFilter | |||
There was a problem hiding this comment.
This is unfortunate because without this doc comment one can no longer jump into the implementation with a single click.
There was a problem hiding this comment.
ok, reverted. Reported rectorphp/rector#8633
let's see if this is a bug or if there are any arguments supporting this behavior
|
Ok, this is a bug from Rector, I will merge with the exclusion and later we will remove the code added in this PR. However, please read the issue, these phpdocs will be removed with another set in Rector - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.