Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Force mutators to include remedies #1954

Merged

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Apr 11, 2024

This PR is a rebased version of #1907.

It currently skips all but one mutator to set a baseline. Existing mutators should no longer be skipped in the future and this check ensures that new mutators will require a remedy to be documented.

There is more to do with remedies to, for example some ideas of #1907 (comment), but I think it is vastly out of scope of this PR and should be considered at a later time.

Closes #1907.

gs-tdewit and others added 5 commits December 13, 2023 20:17
In order to improve the developer experience this PR
forces Mutators to include remedies in their definitions.
Copy link
Member

@sidz sidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@theofidry theofidry merged commit 7bd2ce3 into infection:master Apr 12, 2024
56 checks passed
@theofidry theofidry deleted the force-mutators-to-include-remedies branch April 12, 2024 18:44
@theofidry
Copy link
Member Author

Thank you @ttomdewit!

@ttomdewit
Copy link

Thank you @ttomdewit!

Thank you! 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants