Require coverage metadata in phpunit.xml.dist #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change, each class should have `#[CoversClass()]` annotation
This reverts commit 9fba12b.
|
Thank you @sanmai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require coverage metadata in
phpunit.xml.dist.If any test class will not have
CoversClassattribute, tests will fail (test becomes risky, see proof)Why is it needed?
--map-source-class-to-testinto InfectionDoes build fail if attribute isn't added to a test class?
Yes, phpunit will return non-zero exit code
In the next PR, I will introduce rector rule that I've used to automatically add
CoversClassin this PR, and which will be used on CI here at Infection.