Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InitialTestsRunnerTest #1938

Merged
merged 2 commits into from Mar 20, 2024
Merged

Fix InitialTestsRunnerTest #1938

merged 2 commits into from Mar 20, 2024

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Mar 20, 2024 •
edited

This PR:

It looks like we are testing that Process::run() gets called more than once. The next test tests this behavior too, so we can drop it here.

Testing instructions:

php vendor/bin/phpunit tests/phpunit/Process/Runner/InitialTestsRunnerTest.php --repeat=1000 --stop-on-failure --filter=test_it_creates_a_process

@sanmai sanmai marked this pull request as ready for review March 20, 2024 01:24
@sanmai sanmai enabled auto-merge (squash) March 20, 2024 01:24
maks-rafalko
maks-rafalko approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, if I got it right, that was weird :)

Thanks!

@sanmai sanmai merged commit fa66b4a into infection:master Mar 20, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidz sidz sidz approved these changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Randomly failing test
3 participants
@sanmai @sidz @maks-rafalko