Correctly handle exception code mutants #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romm
changed the title
|
I think this is the same issue as #1673 and the root cause is because coverage driver doesn't mark this line as covered. So in the first place this is not an Infection bug. However, we did a fix previously for similar issue and if you want to help fixing this issue with exceptions, please look at #655 |
|
Thanks for the hint, I'll try to take a look at it. 🙂 |
|
This PR will be solved with #1777 and work done in sebastianbergmann/php-code-coverage#964. I can close this PR, but we could also rebase on WDYT? |
|
If you have time and energy to wait & rebase and complete this test, that would be awesome IMO |
romm
force-pushed
the
fix/exception-code-mutants-uncovered
branch
from
7bb8da1
to
8557d95
Compare
maks-rafalko
approved these changes
Apr 5, 2023
|
Thank you for the reminder! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having this issue but don't really know where to start in order to fix this, so I thought the best way would be to provide a failing test.
When Infection creates the
DecrementIntegerandIncrementIntegermutants on an exception code, even if this code is part of a test, the report will mark those two mutants as uncovered. Changing the code manually leads to a failing test.Any hint on how we could fix this behavior?