Correclty prefix PHAR to avoid Composer\* namespaces conflicts with the application code
#1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/xdebug-handler` of 1.* version
* Remove `Composer\*` from `whitelist` * Upgrade Box from 3.16.0 to 4.0.2 * Add static `prefix` - "Infected" for more convenient debugging and comparing files in different generated PHARs * Add `exclude-classes` setting with `\Composer\InstalledVersions::class` file. This is needed because by default PHP-Scoper does not use previxed class name inside `autoload_classmap.php` file (is it a bug?): 'Composer\\InstalledVersions' => $vendorDir . '/composer/InstalledVersions.php', so we don't need to prefix it in our code
…ion runs build with PHP 8.0 as well
maks-rafalko
force-pushed
the
bugfix/prefix-composer-namespace
branch
from
5f9f43c
to
c76b1f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677
Previously, we excluded the whole
Composer\*namespace from prefixing, leaving it as is. And since Infection usescomposer/xdebug-handlerv2, it failed for all the projects that use v1 because of incompatible API.This PR prefixes all the classes in
Composer\*, except one.I believe there is still a bug in Box/PHP-Scoper which I reported and had to workaround it humbug/php-scoper#678
With this workaround it works and the new e2e test that fails for
masternow works in this branch