Drop symfony/* below 5.4
#1695
Merged
Drop symfony/* below 5.4
#1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that currently I don't know if this is necessary or not :) What is the main benefit of this update? Does it solve any issue? |
The only benefit would be keeping things clean and consistent.
Not that I know of. |
Slamdunk
approved these changes
Jun 8, 2022
maks-rafalko
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Ok, since Symfony <5.4 versions are not supported anymore (except 4.4 LTS) and since users who still use outdated versions can use older Infection versions - I think it's good to go from my side.
@martinssipenko may I ask you to rebase and push? Thank you.
|
Thank you @martinssipenko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Drops
symfony/*below5.4and allows to install6.xversions of dev deps.I created this as a follow-up of #1693 where
symfony/filesystembelow5.4was dropped, if you think this is not necessary just close the PR.