Create MutationExecutionResult instance with real path always, not mixed
#1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixed Fixes #1650 Previously, we could have a mix of real paths and relative paths in `MutationExecutionResult` instances. This broke HTML logger, which assumes that all paths are real (absolute), to find the base common path (`Path::getLongestCommonBasePath`).
sanmai
approved these changes
Jan 19, 2022
|
Thank you @sanmai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1650
Previously, we could have a mix of real paths and relative paths in
MutationExecutionResultinstances.This broke HTML logger, which assumes that all paths are real (absolute), to find the base common path (
Path::getLongestCommonBasePath).