Mark Mutant as killed if Test Framework returns non-zero exit code #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit can return "Tests passed! OK (10 tests, 32 assertions)" output, however return code will be non-zero. This happens when, for example, `symfony/phpunit-bridge` is used, and it detects outstanding deprecations which fails PHPUnit execution, while all the tests are passing See #1620 (comment) Now, when Test Framework exit code is > 100, Mutant will be treated as `E`rrored (retained behavior). When Test Framework exit code is non-zero, Mutant will be treated as Killed (new behavior), even if from output's point of view tests pass.
sanmai
approved these changes
Dec 22, 2021
|
thank you, @sanmai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit can return
"Tests passed! OK (10 tests, 32 assertions)"output, however return code will be non-zero.This happens when, for example,
symfony/phpunit-bridgeis used withSYMFONY_DEPRECATIONS_HELPER=max[self]=0, and it detects outstanding deprecations which fails PHPUnit execution, while all the tests are passingSee #1620 (comment)
Now, when Test Framework exit code is > 100, Mutant will be treated as
Errored (retained behavior).When Test Framework exit code is non-zero, Mutant will be treated as Killed (new behavior), even if from output's point of view tests pass.