fix: adjust signature of inherited method #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infection currently requires: `symfony/finder:^3.4.29 || ^4.1.19 || ^5.0 || ^6.0` In version ^5.0, the signature of the following parameter changed: `MultiplePcreFilterIterator::toRegex(string $str)` In version ^6.0, the return type of the method changed as well. To ensure inheritance compatibility, the signature of the method `RealPathFilterIterator::toRegex` is changed.
|
To give more context, I encountered this issue in this pipeline: https://github.com/CuyZ/Valinor/runs/4540940879?check_suite_focus=true#step:11:20 |
maks-rafalko
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
It is unfortunate our tests do not catch this.
yes. This can be tested after implementing what @sidz has suggested
IMO we need to test Infection against all supported versions.
similar what we did in infection/phpspec-adapter#12
|
Thank you @romm |
|
That was fast! Thank you for this awesome tool. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infection currently requires:
symfony/finder:^3.4.29 || ^4.1.19 || ^5.0 || ^6.0In version ^5.0, the signature of the following parameter changed:
MultiplePcreFilterIterator::toRegex(string $str)In version ^6.0, the return type of the method changed as well.
To ensure inheritance compatibility, the signature of the method
RealPathFilterIterator::toRegexis changed.