Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #1606

Merged
merged 2 commits into from Dec 1, 2021
Merged

Allow Symfony 6 #1606

merged 2 commits into from Dec 1, 2021

Conversation

julien-boudry
Copy link
Contributor

No description provided.

Copy link
Member

@sidz sidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we need to test Infection against all supported versions.

similar what we did in infection/phpspec-adapter#12

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The lock file is not up to date with the latest changes in composer.json, it is recommended that you run composer update or composer update <package name>.

to fix the failed build, please do composer update --lock

@julien-boudry and everyone interested: you can use PHAR distribution instead, unless this one is released. PHAR distribution is prefixed and won't have any conflicts with your Symfony application, including 6.0

@maks-rafalko maks-rafalko merged commit a9e7c20 into infection:master Dec 1, 2021
@maks-rafalko
Copy link
Member

IMO we need to test Infection against all supported versions.

agree

let's merge it as is to allow people to upgrade and use it on their own risk for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants