Add dg/bypass-finals to the conflict packages list #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| @@ -67,7 +67,8 @@ | |||
| "webmozart/path-util": "^2.3" | |||
| }, | |||
| "conflict": { | |||
| "phpunit/php-code-coverage": ">9 <9.1.4" | |||
| "phpunit/php-code-coverage": ">9 <9.1.4", | |||
| "dg/bypass-finals": "*" | |||
There was a problem hiding this comment.
Suggested change
| "dg/bypass-finals": "*" | |
| "dg/bypass-finals": "*" |
There was a problem hiding this comment.
also, please run composer update --lock to fix
- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run
composer updateorcomposer update <package name>.
maks-rafalko
approved these changes
Nov 25, 2021
sanmai
approved these changes
Nov 25, 2021
|
I feel like this is a conflict for |
yes and no. Someone should still be able to use interceptor (for whatever reason) without Infection, even if they use bypass-finals. So let's add it here for now just to avoid Infection's users time waste. I really hope we will soon revert it if bypass-finals's author answers to me here dg/bypass-finals#9 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the library dg/bypass-finals to the conflict section of composer.json file since infection and bypass-finals aren't compatibles yet.
Related to #1275