Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Concat does not generate mutant when both operands are the same #1602

Merged
merged 7 commits into from Oct 31, 2021
Merged

feat: Concat does not generate mutant when both operands are the same #1602

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6dc7c95
feat: Concat does not generate mutant when both operands are the same
michalbundyra Oct 29, 2021
1981155
Update ConcatTest.php
michalbundyra Oct 29, 2021
38c9321
use prettyPrint instead of prettyPrintExpr
michalbundyra Oct 29, 2021
9dfa63a
add clone per review suggestion
michalbundyra Oct 30, 2021
46d74fe
suppress psalm issue - ImpureMethodCall
michalbundyra Oct 31, 2021
730f3ff
Update Concat.php
michalbundyra Oct 31, 2021
c1bc821
suppress issue in psalm.xml
michalbundyra Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Mutator/Operator/Concat.php
View file
Open in desktop
Expand Up @@ -93,7 +93,7 @@ public function mutate(Node $node): iterable

$newNode = new Node\Expr\BinaryOp\Concat($left, $right);

/** @psalm-suppress ImpureMethodCall */
michalbundyra marked this conversation as resolved.
Show resolved Hide resolved
/* @psalm-suppress ImpureMethodCall */
if ($printer->prettyPrint([clone $node]) !== $printer->prettyPrint([$newNode])) {
yield $newNode;
}
Expand Down