Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Infection execution with 0 exit code when git diff filter returns empty result #1600

Merged
merged 4 commits into from Oct 28, 2021
Merged

Stop Infection execution with 0 exit code when git diff filter returns empty result #1600

merged 4 commits into from Oct 28, 2021

Commits on Oct 27, 2021

  1. Use Symfony's Process::fromShellCommandLin() to execute a command

    @maks-rafalko
    maks-rafalko committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    956b651 View commit details
    Browse the repository at this point in the history

  2. Stop Infection execution with 0 exit code when git diff filter retu… 

    …rns empty result (no files to be mutated)
    @maks-rafalko
    maks-rafalko committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7b995c2 View commit details
    Browse the repository at this point in the history

  3. Stop Infection execution with 0 exit code when git diff filter retu… 

    …rns empty result (no files to be mutated)

Fixes #1599

This will improve the speed of CI builds and immediately stop Infection execution.

Example: if `README.md` is updated on the root of the folder, we don't want/need to run Infection against the whole project.
    @maks-rafalko
    maks-rafalko committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    de6048b View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Depending on OS, check command line differently 

    https://www.php.net/manual/en/function.escapeshellarg.php

> On Windows, escapeshellarg() instead replaces percent signs, exclamation marks (delayed variable substitution) and double quotes with spaces and adds double quotes around the string.
    @maks-rafalko
    maks-rafalko committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    1193c15 View commit details
    Browse the repository at this point in the history