New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect syntax errors during mutation analysis and differentiate them from all errors #1555
Changes from all commits
28ac113
0620840
2773767
4a375e6
6891a16
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,81 @@ | ||||||||||||||||
<?php | ||||||||||||||||
/** | ||||||||||||||||
* This code is licensed under the BSD 3-Clause License. | ||||||||||||||||
* | ||||||||||||||||
* Copyright (c) 2017, Maks Rafalko | ||||||||||||||||
* All rights reserved. | ||||||||||||||||
* | ||||||||||||||||
* Redistribution and use in source and binary forms, with or without | ||||||||||||||||
* modification, are permitted provided that the following conditions are met: | ||||||||||||||||
* | ||||||||||||||||
* * Redistributions of source code must retain the above copyright notice, this | ||||||||||||||||
* list of conditions and the following disclaimer. | ||||||||||||||||
* | ||||||||||||||||
* * Redistributions in binary form must reproduce the above copyright notice, | ||||||||||||||||
* this list of conditions and the following disclaimer in the documentation | ||||||||||||||||
* and/or other materials provided with the distribution. | ||||||||||||||||
* | ||||||||||||||||
* * Neither the name of the copyright holder nor the names of its | ||||||||||||||||
* contributors may be used to endorse or promote products derived from | ||||||||||||||||
* this software without specific prior written permission. | ||||||||||||||||
* | ||||||||||||||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||||||||||||||||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||||||||||||||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||||||||||||||||
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||||||||||||||||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||||||||||||||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||||||||||||||||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||||||||||||||||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||||||||||||||||
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||||||||||||||||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||||||||||||||||
*/ | ||||||||||||||||
|
||||||||||||||||
declare(strict_types=1); | ||||||||||||||||
|
||||||||||||||||
namespace Infection\Mutator; | ||||||||||||||||
|
||||||||||||||||
use PhpParser\Node; | ||||||||||||||||
|
||||||||||||||||
/** | ||||||||||||||||
* @internal | ||||||||||||||||
* | ||||||||||||||||
* @implements Mutator<Node\Expr\Variable> | ||||||||||||||||
*/ | ||||||||||||||||
final class SyntaxError implements Mutator | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From what i understand it's for testing only right? So why registering the mutator here in source code? I guess we don't have (yet) a way to register mutators only the fly for tests only? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's for testing only, yes as far as I know, we can't register mutators on the fly atm. If we remove infection/src/Mutator/MutatorFactory.php Lines 59 to 65 in b07e053
|
||||||||||||||||
{ | ||||||||||||||||
use GetMutatorName; | ||||||||||||||||
|
||||||||||||||||
public static function getDefinition(): ?Definition | ||||||||||||||||
{ | ||||||||||||||||
return new Definition( | ||||||||||||||||
'Replaces a `$this` with `false` to produce a syntax error. Internal usage only.', | ||||||||||||||||
MutatorCategory::ORTHOGONAL_REPLACEMENT, | ||||||||||||||||
null, | ||||||||||||||||
<<<'DIFF' | ||||||||||||||||
class X { | ||||||||||||||||
function foo() | ||||||||||||||||
{ | ||||||||||||||||
- $this->method(); | ||||||||||||||||
+ $->method(); | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
DIFF | ||||||||||||||||
); | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
/** | ||||||||||||||||
* @psalm-mutation-free | ||||||||||||||||
* | ||||||||||||||||
* @return iterable<Node\Expr\ConstFetch> | ||||||||||||||||
*/ | ||||||||||||||||
public function mutate(Node $node): iterable | ||||||||||||||||
{ | ||||||||||||||||
yield new Node\Expr\ConstFetch(new Node\Name('$')); | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
public function canMutate(Node $node): bool | ||||||||||||||||
{ | ||||||||||||||||
return $node instanceof Node\Expr\Variable && $node->name === 'this'; | ||||||||||||||||
} | ||||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal usage only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #1557