Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mark Mutant as Killed when no tests were executed #1546

Merged
merged 1 commit into from Aug 7, 2021
Merged

Do not mark Mutant as Killed when no tests were executed #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/TestFramework/PhpUnit/Adapter/PhpUnitAdapter.php
View file
Open in desktop
Expand Up @@ -136,7 +136,10 @@ public function testsPass(string $output): bool
// "Warnings!" - e.g. when deprecated functions are used, but tests pass
$isWarning = preg_match('/warnings!/i', $output);

return $isOk || $isOkWithInfo || $isWarning;
// "No tests executed!" - e.g. when --filter option contains too large regular expression
$isNoTestsExecuted = preg_match('/No tests executed!/i', $output);

return $isOk || $isOkWithInfo || $isWarning | $isNoTestsExecuted;
}

public function getMemoryUsed(string $output): float
Expand Down
2 changes: 2 additions & 0 deletions tests/phpunit/TestFramework/PhpUnit/Adapter/PhpUnitAdapterTest.php
View file
Open in desktop
Expand Up @@ -275,6 +275,8 @@ public function outputProvider(): iterable
yield ['FAILURES!', false];

yield ['ERRORS!', false];

yield ['No tests executed!', true];
}

public function memoryReportProvider(): iterable
Expand Down