Add Mutators: SpreadAssignment, SpreadRemoval

resources/schema.json

@@ -323,7 +323,9 @@
                 "NewObject": { "$ref": "#/definitions/default-mutator-config" },
                 "This": { "$ref": "#/definitions/default-mutator-config" },
                 "Spaceship": { "$ref": "#/definitions/default-mutator-config" },
-                "Spread": { "$ref": "#/definitions/default-mutator-config" },
+                "SpreadOneItem": { "$ref": "#/definitions/default-mutator-config" },
+                "SpreadAssignment": { "$ref": "#/definitions/default-mutator-config" },
+                "SpreadRemoval": { "$ref": "#/definitions/default-mutator-config" },
                 "Foreach_": { "$ref": "#/definitions/default-mutator-config" },
                 "For_": { "$ref": "#/definitions/default-mutator-config" },
                 "DoWhile": { "$ref": "#/definitions/default-mutator-config" },

src/Mutator/Operator/SpreadAssignment.php

@@ -0,0 +1,107 @@
+<?php
+/**
+ * This code is licensed under the BSD 3-Clause License.
+ *
+ * Copyright (c) 2017, Maks Rafalko
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * * Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ * * Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ * * Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+declare(strict_types=1);
+
+namespace Infection\Mutator\Operator;
+
+use function count;
+use Infection\Mutator\Definition;
+use Infection\Mutator\GetMutatorName;
+use Infection\Mutator\Mutator;
+use Infection\Mutator\MutatorCategory;
+use PhpParser\Node;
+use Webmozart\Assert\Assert;
+
+/**
+ * @internal
+ *
+ * @implements Mutator<Node\Expr\Array_>
+ */
+final class SpreadAssignment implements Mutator
+{
+    use GetMutatorName;
+
+    public static function getDefinition(): ?Definition
+    {
+        return new Definition(
+            <<<'TXT'
+Removes a spread operator in an array expression and turns it into an assignment. For example:
+
+```php
+$x = [...$collection];
+```
+
+Will be mutated to:
+
+```php
+$x = $collection;
+```
+TXT
+            ,
+            MutatorCategory::SEMANTIC_REDUCTION,
+            null,
+            <<<'DIFF'
+- $x = [...$collection];
++ $x = $collection;
+DIFF
+        );
+    }
+
+    /**
+     * @psalm-mutation-free
+     *
+     * @return iterable<Node\Expr>
+     */
+    public function mutate(Node $node): iterable
+    {
+        Assert::allNotNull($node->items);
+
+        yield $node->items[0]->value;
+    }
+
+    public function canMutate(Node $node): bool
+    {
+        if (!$node instanceof Node\Expr\Array_) {
+            return false;
+        }
+
+        if (count($node->items) !== 1) {
+            return false;
+        }
+
+        Assert::allNotNull($node->items);
+
+        return $node->items[0]->unpack;
+    }
+}

src/Mutator/Operator/Spread.php → src/Mutator/Operator/SpreadOneItem.php

@@ -46,7 +46,7 @@
  *
  * @implements Mutator<Node\Expr\ArrayItem>
  */
-final class Spread implements Mutator
+final class SpreadOneItem implements Mutator
 {
     use GetMutatorName;
 

src/Mutator/Operator/SpreadRemoval.php

@@ -0,0 +1,99 @@
+<?php
+/**
+ * This code is licensed under the BSD 3-Clause License.
+ *
+ * Copyright (c) 2017, Maks Rafalko
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * * Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ * * Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ * * Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+declare(strict_types=1);
+
+namespace Infection\Mutator\Operator;
+
+use Infection\Mutator\Definition;
+use Infection\Mutator\GetMutatorName;
+use Infection\Mutator\Mutator;
+use Infection\Mutator\MutatorCategory;
+use PhpParser\Node;
+
+/**
+ * @internal
+ *
+ * @implements Mutator<Node\Expr\ArrayItem>
+ */
+final class SpreadRemoval implements Mutator
+{
+    use GetMutatorName;
+
+    public static function getDefinition(): ?Definition
+    {
+        return new Definition(
+            <<<'TXT'
+Removes a spread operator in an array expression. For example:
+
+```php
+$x = [...$collection, 4, 5];
+```
+
+Will be mutated to:
+
+```php
+$x = [$collection, 4, 5];
+```
+TXT
+            ,
+            MutatorCategory::SEMANTIC_REDUCTION,
+            null,
+            <<<'DIFF'
+- $x = [...$collection, 4, 5];
++ $x = [$collection, 4, 5];
+DIFF
+        );
+    }
+
+    /**
+     * @psalm-mutation-free
+     *
+     * @return iterable<Node\Expr\ArrayItem>
+     */
+    public function mutate(Node $node): iterable
+    {
+        yield new Node\Expr\ArrayItem(
+            $node->value,
+            null,
+            false,
+            $node->getAttributes(),
+            false
+        );
+    }
+
+    public function canMutate(Node $node): bool
+    {
+        return $node instanceof Node\Expr\ArrayItem && $node->unpack;
+    }
+}

src/Mutator/ProfileList.php

@@ -158,7 +158,9 @@ final class ProfileList
         Mutator\Operator\Finally_::class,
         Mutator\Operator\NullSafeMethodCall::class,
         Mutator\Operator\NullSafePropertyCall::class,
-        Mutator\Operator\Spread::class,
+        Mutator\Operator\SpreadAssignment::class,
+        Mutator\Operator\SpreadOneItem::class,
+        Mutator\Operator\SpreadRemoval::class,
         Mutator\Operator\Ternary::class,
         Mutator\Operator\Throw_::class,
     ];
@@ -361,7 +363,9 @@ final class ProfileList
         'Finally_' => Mutator\Operator\Finally_::class,
         'NullSafeMethodCall' => Mutator\Operator\NullSafeMethodCall::class,
         'NullSafePropertyCall' => Mutator\Operator\NullSafePropertyCall::class,
-        'Spread' => Mutator\Operator\Spread::class,
+        'SpreadAssignment' => Mutator\Operator\SpreadAssignment::class,
+        'SpreadOneItem' => Mutator\Operator\SpreadOneItem::class,
+        'SpreadRemoval' => Mutator\Operator\SpreadRemoval::class,
         'Ternary' => Mutator\Operator\Ternary::class,
         'Throw_' => Mutator\Operator\Throw_::class,