Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set XDEBUG_MODE for processes with coverage #1518
Set XDEBUG_MODE for processes with coverage #1518
Changes from 34 commits
5390f63
317e5ce
f71de68
fd77c35
90017c6
6dd84fe
a8a3db7
a645bee
99162ef
6f72869
4999b9a
97ba8e1
5fd95df
41433ee
aa1e089
fd56f5d
8af83b2
7b12fc4
8070082
ceee8e2
9f6d313
ae72703
c3aa985
9925caf
cccb00f
51f3d8f
ba71b3b
b59fe4f
2d9435e
2b6b4d0
a7c2f2f
394e1dc
4597545
eec4a33
e958091
db7bd12
2b7aa7b
e363c79
50ee06f
17f84ee
4270a9b
2b8a324
20a9b99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand this block.
XDEBUG_MODE=coverage
whenpcov
is loaded, for example?In the end the user is still in control: they can provide XDEBUG_MODE=coverage on their own.
- is it true? If user passesXDEBUG_MODE=debug
and Xdebug is loaded (with, let's say,off
mode), then this new code will override it byXDEBUG_MODE=coverage
, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XDEBUG_MODE=coverage
even if they have PCOV loaded. We can't guarantee other tools will pick this up, but at least we're not standing in the way.XDEBUG_MODE=debug
is no use for us, we have to override it withXDEBUG_MODE=coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, all should be much more clear in
shallExtendEnvironmentWithXdebugMode
below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we're using Xdebug 3 (as
XdebugHandler
won't offload Xdebug if Xdebug isn't enabled)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in #1518 (comment), seems like here
||
also probably needs to be replaced with&&
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need to properly DI test this, without this
extension_loaded
nonsense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three weeks later DI stuff isn't here, but it looks like I was able to figure it out: here we assume that
XDEBUG_MODE=coverage
is set unless we're running with PCOV, or under PHPDBG, or with Xdebug <3. Checking forXdebugHandler
here is a foul business: we never invoke it for tests.