Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8 specific NullSafe operator mutators #1457

Merged
merged 6 commits into from Dec 8, 2020
Merged

Add PHP 8 specific NullSafe operator mutators #1457

merged 6 commits into from Dec 8, 2020

Conversation

sidz
Copy link
Member

@sidz sidz commented Dec 7, 2020 •
edited

This PR:

NullSafeMethodCall Mutator:

- $object?->getObject()?->getName()
+ $object->getObject()?->getName()

and

- $object?->getObject()?->getName()
+ $object?->getObject()->getName()

NullSafePropertyCall Mutator:

- $object?->property?->name
+ $object->property?->name

and

- $object?->property?->name
+ $object?->property->name

I'm not sure how to exclude these mutators from the schema.json for case when Infection is executed on PHP < 8. Or maybe it won't be an issue as they won't be executed anyway due to PHP_VERSION_ID check.

@sidz sidz added the Mutator label Dec 7, 2020
@sidz sidz self-assigned this Dec 7, 2020
@maks-rafalko maks-rafalko added this to the 0.21.0 milestone Dec 7, 2020
maks-rafalko
maks-rafalko approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

tests/phpunit/Mutator/Operator/NullSafePropertyCallTest.php Show resolved Hide resolved
sidz added a commit to infection/site that referenced this pull request Dec 8, 2020
@sidz
Update mutators.md with new NullSafe mutators
6f9b997 
ref: infection/infection#1457
@sidz sidz mentioned this pull request Dec 8, 2020
Merged
@maks-rafalko
Copy link
Member

Cool, thank you @sidz

@maks-rafalko maks-rafalko merged commit c604d29 into master Dec 8, 2020
@maks-rafalko maks-rafalko deleted the null-safe-call-mutators branch December 8, 2020 10:52
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees

@sidz sidz

Labels
Mutator
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidz @maks-rafalko