New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preg match regex mutators #2 #1455
Conversation
<?xml version="1.0" encoding="UTF-8"?> | ||
<files psalm-version="4.1.1@16bfbd9224698bd738c665f33039fade2a1a3977"> | ||
<file src="src/Mutator/Regex/PregMatchRemoveCaret.php"> | ||
<ImpureFunctionCall occurrences="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, thecodingmachine/safe
package does not support Psalm's annotations yet, and functions are missing @pure
annotation, that's why we have issues reported by Psalm.
Tried https://github.com/hectorj/safe-php-psalm-plugin, but it doesn't work properly, so for now it's ok to suppress them
…dd support for all possible delimiters
…upport psalm annotations yet thecodingmachine/safe#141
4ef0d13
to
d0dd870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nitpick
Thank you @BackEndTea |
This PR is a rebirth of #388
Fixes #324
2 new mutations here:
Other possible mutations will be done in a separate PRs after this one is merged.