Add ignoreSourceCodeByRegex key for custom mutator definitions
#1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384
The root error from 1384:
Currently, we have the following issue: when we add a new key to
default-mutator-configdefinition, we have to add such key for every custom definition. This is what I forget to do, and this is what this PR does.It fixes the issue, but we will definitely have the same issue in the future because someone will forget to add new key to custom definitions as well.
I tried to fix this second issue by using Extending in JSON schema, but this brings new issues.
Let's get it merged to fix the issue, and discuss extending in a separate PR.