Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix PHPDBG builds #1364

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Oct 22, 2020

This PR:

  • Attempts to fix PHPDBG builds

Ref: sebastianbergmann/phpunit#4486

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

.travis.yml Outdated
if [[ "$DRIVER" != "phpdbg" ]]; then
$PHPUNIT_BIN;
else
sed -i s/stream_get_contents/@stream_get_contents/ vendor/phpunit/phpunit/src/Util/PHP/Template/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a comment above this line explaining that it's related to

Ref: sebastianbergmann/phpunit#4486

will be easier to understand what is going on here in the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. How about now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.travis.yml Outdated Show resolved Hide resolved
@sanmai sanmai merged commit ad92237 into infection:master Oct 22, 2020
@sanmai sanmai deleted the pr/2020-10/fix-phpdbg-builds branch October 22, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants