Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.3 #1340

Merged
merged 1 commit into from Oct 17, 2020
Merged

Drop support for PHP 7.3 #1340

merged 1 commit into from Oct 17, 2020

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Oct 17, 2020

php_roadmap

Active support for PHP 7.3 is finished on 6 Dec 2020. Here is the first of several PRs to drop support for PHP 7.3 in Infection.

Infection 0.18, which I will release soon, will be the last Infection version with PHP 7.3 support.

Nexts PRs:

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but otherwise all good.

dependencies: ['']
include:
- { php-version: '7.3', dependencies: '--prefer-lowest' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to leave it but change 7.3 to 7.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

sanmai added a commit to sanmai/infection that referenced this pull request Oct 17, 2020
Use of compatibility package is no longer needed on PHP 7.4+

Follow-up to infection#1340
* Remove PHP 7.3 from CI matrix
@maks-rafalko maks-rafalko added this to the 0.19 milestone Oct 17, 2020
@maks-rafalko maks-rafalko merged commit 88d0e3d into master Oct 17, 2020
@maks-rafalko maks-rafalko deleted the feature/drop-7.3 branch October 17, 2020 21:15
@maks-rafalko
Copy link
Member Author

Thank you @sanmai

sanmai added a commit that referenced this pull request Oct 18, 2020
* Switch to use ocramius/package-versions

Use of compatibility package is no longer needed on PHP 7.4+

Follow-up to #1340

* composer update

* Fix PHPStan warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants