Set failOnRisky, failOnWarning to true if parameters are not already set
#1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ready set Fixes #1274 Since PHPUnit won't treat new risky tests as failures by default, and since this behavior causes an unnecessary confusion even for experienced users (see #1273), we add failOnRisky="true" and failOnWarning="true" by default unless a conflicting directive is present, just like we do with executionOrder="random". That is, if there's already failOnRisky="false" then it should not be changed.
sanmai
approved these changes
Jul 7, 2020
|
Thank you, @sanmai. |
|
@sanmai it looks like I've implemented this feature for the initial tests run, while from what I understand we wanted this for the mutant phpunit execution, so that if Infection changes the code and tests become risky/with warning, then Mutant becomes killed. What do you think about if I add the same to Related to #1620. For me it makes sense and it would fix this bug report atuomatically |
|
Yeah, looks like this is going to make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1274