Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force-progress option to opt-out the CI detection #1261

Merged
merged 8 commits into from Apr 25, 2020

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Apr 25, 2020

  • Add a new --force-progress which disables the CI detection, effectively ensuring the user will see all the progress bars and the mutation count (during the run – the ones in the summary are always displayed independently from noProgress)
  • Ensures the options forceProgress and noProgress cannot be set together both from the CLI or by manipulation the container directly
  • Replaces the regular usage of CiDetector by MemoizedCiDetector which memoize the CI detection call

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Command/RunCommand.php Outdated Show resolved Hide resolved
tmp Outdated Show resolved Hide resolved
@theofidry theofidry changed the title PoC: Add option to opt-out the CI detection Add option to opt-out the CI detection Apr 25, 2020
@theofidry theofidry marked this pull request as ready for review April 25, 2020 10:42
@theofidry theofidry merged commit 5a2d5a1 into infection:master Apr 25, 2020
@maks-rafalko maks-rafalko added this to the 0.17.0 milestone Apr 25, 2020
@maks-rafalko
Copy link
Member

We forgot about documenting this new option. Could you please add a PR to the docs?

@maks-rafalko maks-rafalko changed the title Add option to opt-out the CI detection Add --no-progress option to opt-out the CI detection Aug 3, 2020
maks-rafalko added a commit to infection/site that referenced this pull request Aug 3, 2020
Also, add a documentation for `--force-progress` option from infection/infection#1261
@sanmai sanmai changed the title Add --no-progress option to opt-out the CI detection Add --force-progress option to opt-out the CI detection Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants