Log the debuggers found via the logger instead of ConsoleOutput

[theofidry]

I'm trying to play with the logs displayed as I think there is a few things that could be improved there. However I believe this small change could add to the noise hence is worth extracting in a separate PR.

As a result here is this PR which is a small tweak on the ConsoleLogger. What does it do?

In 0.16.3:

In master (due to #1263):

Now:

So in other words:

• the "notice" output (without "IO block") is a very plain message, pretty much what you get with a plain writeln()
• the other outputs (other log level) are as "normal" – standard Symfony Console

(since #1263 those are like so):

[theofidry]

@sanmai @maks-rafalko do you know where I should look at to see how infection resolves which debugger to use?

[maks-rafalko]

What is a "debugger" in this context? :)

[theofidry]

sorry I meant code coverage generator... Guess I was too tired :D

[sanmai]

I don't think it does. This is a testing tool's job. E.g. PHPUnit's.

[maks-rafalko]

I don't think it does. This is a testing tool's job. E.g. PHPUnit's.

Exactly. I guess it's here

https://github.com/sebastianbergmann/php-code-coverage/blob/28efe6950c2c3ceb86f0fc63aa077617950c78c5/src/CodeCoverage.php#L891-L908

[sanmai]

Also note it wasn't like this as of late 2019. Back then XDebug was used over PCOV if both were present.

[theofidry]

note that this test doesn't capture the formatter tags e.g. here the message that we write is <debug>[debug] message</debug> where the tags are handled by the output formatter. I'm don't know however how to test that...

[maks-rafalko]

LGTM.

What do you think about moving

Xdebug detected

below the LOGO?

IMO it's prettier when we have Infection logo first, then all the rest information, as shown here

Or it's impossible?

[theofidry]

Good idea, done