Ignore bogus "not installed" exception from PackageVersions #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
sanmai
commented
Mar 11, 2020
| // We have a bogus exception: how can Infection be not installed if we're here? | ||
| $version = 'not-installed'; | ||
| } | ||
| // @codeCoverageIgnoreEnd |
There was a problem hiding this comment.
This happens in very peculiar circumstances which, I think, just not worth the time to be reproduced, even with an E2E test. Therefore not covered by default.
There was a problem hiding this comment.
So what version will be displayed there? Wasn't a case also when you were globally installing infection with --no-scripts?
There was a problem hiding this comment.
With --no-scripts there's no exception here, IIRC. That issue is still open #876
maks-rafalko
approved these changes
Mar 11, 2020
|
Thank you @maks-rafalko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1148