Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PHP 7.2 #1132

Merged
merged 6 commits into from Mar 7, 2020
Merged

Drop support for PHP 7.2 #1132

merged 6 commits into from Mar 7, 2020

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Mar 6, 2020

This PR:

  • Removes PHP 7.2 from supported versions
  • Removes PHP 7.2 from CI
  • Updates dependencies
  • Decreases CI delays

Rationale:

  • PHP 7.2 is past active support deadline, soon reaching EOL.
  • Infection isn't a unit-testing framework, but rather a CI tool, supposed to be run only once per build. If an app supports PHP 7.3, it can run Infection too in one of the jobs.
  • It appears to me PHP 7.2 wasn't as widespread. E.g. Debian jumped 7.3 right from 7.0.

maks-rafalko
maks-rafalko approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that.

Just to think about: probably we can release 0.16 with 7.2 support and then merge this PR.

But, as I said, I'm ok with merging it immediately.

@theofidry
Copy link
Member

theofidry commented Mar 6, 2020 •
edited

@maks-rafalko the current master already contain a bunch of BC breaks so what about making it as part of 0.16 instead of 0.17?

@maks-rafalko
Copy link
Member

👍

@maks-rafalko maks-rafalko added this to the 0.16.0 milestone Mar 6, 2020
@sanmai sanmai merged commit 3b534fa into infection:master Mar 7, 2020
@sanmai sanmai deleted the pr/php-73 branch March 7, 2020 04:38
@sanmai
Copy link
Member Author

sanmai commented Mar 7, 2020

Thank you @maks-rafalko and @theofidry

@sanmai sanmai mentioned this pull request Mar 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
BC break
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sanmai @theofidry @maks-rafalko