New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E2ETest #1120
Update E2ETest #1120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Bummer. Because I didn't change anything in |
@sanmai is it actually run anywhere? |
Not during CI, but we can make it, if you insist. Let's get finished with #1106, and I'll help it. Who knows, it may not need any help. |
I've restarted it, but this shouldn't be an issue, because on |
Fingers crossed. Anyway, merge as you see fit. |
Still no luck, same job :| And now also app veyor is broken (#1110 (comment)) |
There's something seriously wrong with this PR. I'll be having a look later. |
])); | ||
} | ||
|
||
$output = $this->runInfection(self::EXPECT_SUCCESS, [ | ||
'--test-framework-options="--exclude-group=' . self::EXCLUDED_GROUP . '"', | ||
sprintf('--test-framework-options=--exclude-group=%s', self::EXCLUDED_GROUP), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing, but probably quotes affects somehow the build. It's now written in a different way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't help :see_no_evil:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not many cases left to revert :) next is --no-progress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more like something isn't added here.
Curiously, build are broken only for PCOV. |
I'm going to close it with hopes I can revisit the idea later. |
@runInSeparateProcess
.