Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E2ETest #1120

Closed
wants to merge 15 commits into from
Closed

Update E2ETest #1120

wants to merge 15 commits into from

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Mar 5, 2020

@sanmai sanmai requested a review from maks-rafalko March 5, 2020 02:18
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sanmai
Copy link
Member Author

sanmai commented Mar 5, 2020

The job exceeded the maximum time limit for jobs, and has been terminated.

Bummer. Because I didn't change anything in src, it wants to mutate everything.

@theofidry
Copy link
Member

@sanmai is it actually run anywhere?

@sanmai
Copy link
Member Author

sanmai commented Mar 5, 2020

Not during CI, but we can make it, if you insist. Let's get finished with #1106, and I'll help it. Who knows, it may not need any help.

@maks-rafalko
Copy link
Member

Bummer. Because I didn't change anything in src, it wants to mutate everything.

I've restarted it, but this shouldn't be an issue, because on push builds everything is mutated as well.

@sanmai
Copy link
Member Author

sanmai commented Mar 5, 2020

Fingers crossed. Anyway, merge as you see fit.

@maks-rafalko
Copy link
Member

Still no luck, same job :|

And now also app veyor is broken (#1110 (comment))

@sanmai
Copy link
Member Author

sanmai commented Mar 9, 2020

There's something seriously wrong with this PR. I'll be having a look later.

]));
}

$output = $this->runInfection(self::EXPECT_SUCCESS, [
'--test-framework-options="--exclude-group=' . self::EXCLUDED_GROUP . '"',
sprintf('--test-framework-options=--exclude-group=%s', self::EXCLUDED_GROUP),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing, but probably quotes affects somehow the build. It's now written in a different way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't help  :see_no_evil:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not many cases left to revert :) next is --no-progress?

Copy link
Member Author

@sanmai sanmai Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more like something isn't added here.

@sanmai
Copy link
Member Author

sanmai commented Mar 10, 2020

Curiously, build are broken only for PCOV.

@sanmai sanmai marked this pull request as draft August 30, 2020 11:28
@sanmai
Copy link
Member Author

sanmai commented May 10, 2024

I'm going to close it with hopes I can revisit the idea later.

@sanmai sanmai closed this May 10, 2024
@sanmai sanmai deleted the pr/2020-03/E2ETest branch May 10, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2ETest::test_it_runs_on_itself() is broken
3 participants