Allow the initial test suite to be skipped #1042
Conversation
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
This is a very dangerous proposition because if tests are not in the passing state where you think they are, even valid mutations will be looking like they were caught. |
That's true. Even if your tests pass from original PHPUnit run, they can fail when being executed by Infection since this is subprocess, different config, etc. At the same time, I should admit that I needed this option many times, and had to comment out initial tests run right in the code (though, this was during developing). What if we add this option with a big red warning in terminal, explaining all the consequences? Also, this option can be allowed to use only with provided coverage ( |
|
I think a warning is a must. |
|
I will carry on with this when I get some time then, fix the unit tests and add an e2e test for this functionality. Do you want me to prepare a docs PR too, or would you rather decide on the wording yourselves? |
|
Please go ahead with the docs as well 👍 Thank you |
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
from
4fe6d2e
to
f37b21c
Compare
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
2 times, most recently
from
d4830a5
to
6c12e23
Compare
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
from
6c12e23
to
91f92a0
Compare
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
2 times, most recently
from
5e7af45
to
916c574
Compare
|
|
|
Might be cache related: try removing the PHP-CS-Fixer cache and running it again |
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
2 times, most recently
from
0fe1188
to
fc45487
Compare
|
Would you mind checking that "Allow edits from maintainers" checkbox? Else please update the branch. Thanks. |
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
from
fc45487
to
524fc18
Compare
|
I've done both 👍 |
|
Could you look into failing tests please? I will merge it as soon as it's green |
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
from
524fc18
to
9aecc34
Compare
duncan3dc
force-pushed
the
skip-initial-test-suite
branch
from
9aecc34
to
87db226
Compare
|
I think we're all good now, thanks for bearing with me |
|
This is a great contribution, thank you @duncan3dc! |
* New option to skip the initial test suite Doc update for infection/infection#1042 * Style the warning message Co-Authored-By: Maks Rafalko <b0rn@list.ru> Co-authored-by: Maks Rafalko <b0rn@list.ru>
This PR:
In an effort to reduce our build times we started to use the
--coverageoption to use previously generated code coverage stats, however we noticed that Infection still runs the entire test suite before beginning mutations, effectively doubling our build time.I searched through the docs and the only thing I could find that explained this is here:
"This in no way restricts the initial Infection check on the overall test suite which is still executed in full to ensure all tests are passing correctly before proceeding."
If Infection doesn't need any other information from this initial run other than the coverage, then it should be possible to bypass it, which is what this PR allows.
I'll happily add tests and a docs PR, but I didn't want to do too much work in case there was something I'd missed that means this isn't a practical option