Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace abandoned webmozart/path-util with symfony/filesystem #1693

Merged

Conversation

martinssipenko
Copy link
Contributor

@martinssipenko martinssipenko commented May 30, 2022

This PR:

Replaces abandoned webmozart/path-util with symfony/filesystem.

Fixes #1634

@martinssipenko martinssipenko marked this pull request as ready for review May 30, 2022 09:11
@martinssipenko
Copy link
Contributor Author

I just noticed the conversation in #1634 about dropping Symfony below 5.4. Question I have is why do you need to keep those old Symfony versions?

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need it.

image

All the versions below 5.4 EOLd (ok, except 4.4), so personally I'm ok with the current state of this PR.

Users with older SF versions will use Infection <= 0.26.10

@martinssipenko
Copy link
Contributor Author

@maks-rafalko dunno whether 4.4 works on PHP 8.0, which is required for Infection. Will you merge the PR then? I later can follow up with another one to remove < 5.4 altogether.

@maks-rafalko
Copy link
Member

dunno whether 4.4 works on PHP 8.0

according to symfony repostiories and GH Actions, it works even on 8.1

Will you merge the PR then?

yes, right now

I later can follow up with another one to remove < 5.4 altogether.

do you think it's needed? for what reason?

@maks-rafalko maks-rafalko merged commit 62f52df into infection:master May 31, 2022
@maks-rafalko maks-rafalko added this to the next milestone May 31, 2022
@martinssipenko martinssipenko deleted the replace-webmozart-path-util branch May 31, 2022 06:38
@maks-rafalko
Copy link
Member

Released: https://github.com/infection/infection/releases/tag/0.26.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using webmozart/path-util
2 participants